Announce: vtigercrm-4.2.4rc1 Release Candidate available

Comments

• 13 Comments sorted by Votes Date Added
• kiang

  February 2006 Vote Up0Vote Down

  i had no rights to attach file in trac. so i upload the patch here for the ticket:
  <!-- m --><a class="postlink" href="http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37">http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37</a><!-- m -->
• kiang

  February 2006 Vote Up0Vote Down

  a small bug:

  index: vtiger_crm/modules/settings/combofieldlist.php
  ===================================================================
  --- vtiger_crm/modules/settings/combofieldlist.php	(revision 3937)
  +++ vtiger_crm/modules/settings/combofieldlist.php	(working copy)
  @@ -216,6 +216,7 @@
   
   function getuserfldarray($fld_module)
   {
  +	global $adb;
   	$user_fld = array();
   	$query = "select * from field where generatedtype=2 and tabid=".fetchtabidval($fld_module)." and uitype in (15,16)";
   //        echo $query;
  
• BrianLaughlin

  February 2006 Vote Up0Vote Down

  a huge thanks to the following:
  
  mfedyk
  jeffk
  allanbush
  fathi
  mmbrich
  and anyone else that i've missed.
  
  this is awesome...thanks!!
  
  brian
• mikefedyk

  February 2006 Vote Up0Vote Down

  also, thanks go to briand, mikecrowe, kleo, mickie, mjsdev & jisaitua for patches in this release.
• mikefedyk

  February 2006 Vote Up0Vote Down

  "kiang&quot wrote:

  a small bug:

  index: vtiger_crm/modules/settings/combofieldlist.php
  ===================================================================
  --- vtiger_crm/modules/settings/combofieldlist.php	(revision 3937)
  +++ vtiger_crm/modules/settings/combofieldlist.php	(working copy)
  @@ -216,6 +216,7 @@
   
   function getuserfldarray($fld_module)
   {
  +	global $adb;
   	$user_fld = array();
   	$query = "select * from field where generatedtype=2 and tabid=".fetchtabidval($fld_module)." and uitype in (15,16)";
   //        echo $query;
  

  
  can you give a quick description on how to reproduce the problem this fixes?
  
  thanks
• mikefedyk

  February 2006 Vote Up0Vote Down

  "kiang&quot wrote:

  i had no rights to attach file in trac. so i upload the patch here for the ticket:
  <!-- m --><a class="postlink" href="http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37">http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37</a><!-- m -->

  
  thanks for the patch.
  
  attchments can now be added by anonymous users in the trac ticket system now.
• kiang

  February 2006 Vote Up0Vote Down

  "mikefedyk&quot wrote:

  "kiang&quot wrote:

  a small bug:

  index: vtiger_crm/modules/settings/combofieldlist.php
  ===================================================================
  --- vtiger_crm/modules/settings/combofieldlist.php	(revision 3937)
  +++ vtiger_crm/modules/settings/combofieldlist.php	(working copy)
  @@ -216,6 +216,7 @@
   
   function getuserfldarray($fld_module)
   {
  +	global $adb;
   	$user_fld = array();
   	$query = "select * from field where generatedtype=2 and tabid=".fetchtabidval($fld_module)." and uitype in (15,16)";
   //        echo $query;
  

  
  can you give a quick description on how to reproduce the problem this fixes?
  
  thanks

  
  settings => picklist settings => anyone below
  
  error message:
  call to a member function on a non-object in /modules/settings/combofieldlist.php on line 223
  
  example url:
  index.php?module=settings&action=combofieldlist&fld_module=vendor
  
  <!-- s:) --><img src="{smilies_path}/icon_smile.gif" alt=":)" title="smile" /><!-- s:) -->
• kiang

  February 2006 Vote Up0Vote Down

  i published a traditional chinese version here:
  <!-- m --><a class="postlink" href="http://twpug.net/modules/wfdownloads/singlefile.php?cid=36&lid=616">http://twpug.net/modules/wfdownloads/si ... 36&lid=616</a><!-- m -->
  
  this version included a free font for traditional chinese and modified some settings for jpgraph to prevent character errors in the charts. it's not great to download it if you don't use this language. ^^
• mikefedyk

  February 2006 Vote Up0Vote Down

  "kiang&quot wrote:

  i had no rights to attach file in trac. so i upload the patch here for the ticket:
  <!-- m --><a class="postlink" href="http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37">http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/37</a><!-- m -->

  
  hi kiang,
  
  here is your patch with my comments:

  index: vtiger_crm/jpgraph/jpgraph.php
  ===================================================================
  --- vtiger_crm/jpgraph/jpgraph.php	(revision 3937)
  +++ vtiger_crm/jpgraph/jpgraph.php	(working copy)
  @@ -598,11 +598,7 @@
   	    return $this->g2312->gb2utf8($atxt);
   	}
   	elseif( $aff === ff_chinese ) {
  -	    if( !function_exists('iconv') ) {
  -		jpgrapherror::raisel(25006);
  -//('usage of ff_chinese (ff_big5) font family requires that your php setup has the iconv() function. by default this is not compiled into php (needs the "--width-iconv" when configured).');
  -	    }
  -	    return iconv('big5','utf-8',$atxt);
  +	    return $atxt;
   	}
   	else 
   	    return $atxt;
  

  you change the definition of ff_chinese below and then remove warning.
  
  can you add a difinition for utf8 fonts instead of modifying an entry meant for big5 encoded fonts?

  @@ -3086,7 +3082,7 @@
   	    ff_veramono => array(fs_normal=>'veramono.ttf', fs_bold=>'veramobd.ttf', fs_italic=>'veramoit.ttf', fs_bolditalic=>'veramobi.ttf' ),
   	    ff_veraserif => array(fs_normal=>'verase.ttf', fs_bold=>'verasebd.ttf', fs_italic=>'', fs_bolditalic=>'' ) ,
   	    ff_simsun =>  array(fs_normal=>'simsun.ttc',  fs_bold=>'simhei.ttf',   fs_italic=>'',   fs_bolditalic=>'' ),
  -	    ff_chinese => array(fs_normal=>chinese_ttf_font, fs_bold=>'', fs_italic=>'', fs_bolditalic=>'' ),
  +	    ff_chinese => array(fs_normal=>chinese_ttf_font, fs_bold=>chinese_ttf_font, fs_italic=>chinese_ttf_font, fs_bolditalic=>chinese_ttf_font ),
    	    ff_mincho =>  array(fs_normal=>mincho_ttf_font,  fs_bold=>'',   fs_italic=>'',   fs_bolditalic=>'' ),
    	    ff_pmincho => array(fs_normal=>pmincho_ttf_font,  fs_bold=>'',   fs_italic=>'',   fs_bolditalic=>'' ),    
    	    ff_gothic  => array(fs_normal=>gothic_ttf_font,  fs_bold=>'',   fs_italic=>'',   fs_bolditalic=>'' ),    
  index: vtiger_crm/modules/potentials/charts.php
  ===================================================================
  --- vtiger_crm/modules/potentials/charts.php	(revision 3937)
  +++ vtiger_crm/modules/potentials/charts.php	(working copy)
  @@ -50,13 +50,8 @@
   	{
   		case 'cn_zh':
   			return ff_simsun;
  -		case 'tw_zh':
  -			if(!function_exists('iconv')){
  -				echo " unable to display traditional chinese on the graphs.<br>the function iconv does not exists please read more about <a href='http://us4.php.net/iconv'>iconv here</a><br>";
  -				return ff_font1;
  -
  -			}
  -			else return ff_chinese;
  +		case 'zh-tw':
  +			return ff_chinese;
   		default:
   			return ff_font1;
   	}
  

  what happened to 'tw_zh' here?
• kiang

  February 2006 Vote Up0Vote Down

  sorry for misunderstanding. ^^||
  
  about the second problem. 'tw_zh' is no longer exists(and i have no idea why it's there). i used 'zh-tw' because most browser accept it by default.
  
  i'll make a patch for first problem latter with the ticket. <!-- s:) --><img src="{smilies_path}/icon_smile.gif" alt=":)" title="smile" /><!-- s:) -->