Bug in Quote Creation

Comments

• 10 Comments sorted by Votes Date Added
• leokolln

  October 2005 Vote Up0Vote Down

  well, no one answer me, but i solved the problem and i will try explain...
  
  when the system is trying to create the quote, it uses one foreign key for contact id, and other to potential id...
  the problem happen cause i´m using the mysql 4.1 and when happen an insert of a value to a foreign key, it does not accept '', in its place place null, well, to solve this... place this lines of code in the "modules/quotes/save.php"
  

  foreach($focus->column_fields as $fieldname => $val)
  {
  	if(isset($_request[$fieldname]))
  	{
  		$value = $_request[$fieldname];
  
                  // new lines here
                  if(empty($value))
                  {
                        $value = 'null';
                  }
  
  		//echo '<br>';
  		//echo $fieldname."         ".$value;
  		//echo '<br>';
  		$focus->column_fields[$fieldname] = $value;
  	}
  		
  }
  

  
  sorry by the bad english,
  hope have helped.
  
  léo willian kölln
• dfar2008

  October 2005 Vote Up0Vote Down

  thanks a lot , leokolln!
  yesterday night i began to look for solution for the bug which you posted.but i did not find any solution until i reviewed the bug again.
  there is nothing about the bug in the mysql manual.
  
  best regards
  
  dfar
  <!-- m --><a class="postlink" href="http://www.c3crm.com">http://www.c3crm.com</a><!-- m -->
• leokolln

  October 2005 Vote Up0Vote Down

  well, a bug killed, other born...
  
  because of the correction, other issue happen, when you try to list the quotes what you have created, you get an error like this...
  

  fatal error: call to a member function on a non-object in c:\arquivos de programas\apache group\apache2\htdocs\include\database\peardatabase.php on line 434

  
  this happen cause the system try to find a null id of potential... and we don´t have a potential...
  
  to solve this open the file "include/utils.php" and edit
  
  [at line 3127 (or something around this)]
  in place of:

  elseif($module == 'quotes' && $name == 'potential name')
  {
  	$potential_id = $adb->query_result($list_result,$i-1,"potentialid");
  	$potential_name = getpotentialname($potential_id);
  	$value = '<a ref="index.php?module=potentials&action=detailview&record='.$potential_id.'">'.$potential_name.'</a>';
  }
  

  
  put:

  elseif($module == 'quotes' && $name == 'potential name')
  {
  	$potential_id = $adb->query_result($list_result,$i-1,"potentialid");
  	if(!empty($potential_id))
  	{
  		$potential_name = getpotentialname($potential_id);
  		$value = '<a href="index.php?module=potentials&action=detailview&record='.$potential_id.'">'.$potential_name.'</a>';
  	}
  	else
  	{
  		$value = '';
  	}
  }
  

  
  this solved the problem for me, hope for you too... please post here if something like this happen... or more...
  
  for the vtiger developers:
  i think this type of problem is everywere in the system, please take a look on those problems, of if some one read this, please post here.
  
  thanks,
  
  léo willian kölln
• tigerincanada

  October 2005 Vote Up0Vote Down

  please try my collection if fixes for utils.php in this thread:
  
  <!-- m --><a class="postlink" href="http://forums.vtiger.com/viewtopic.php?p=12987#12987">http://forums.vtiger.com/viewtopic.php?p=12987#12987</a><!-- m -->
• nathan

  December 2005 Vote Up0Vote Down

  i tried your patch, but then it only works if i let all the fields empty!
  any thought?
• nathan

  December 2005 Vote Up0Vote Down

  oups sorry, ignore my previous post, i can put anything i want, but why can't i put any other value than "null" like "--" or "___" ??? in the code?
• kenlyle

  May 2006 Vote Up0Vote Down

  i found that applying the 4.2.4 rc2 overwrite/"patch", and the utils.php in <!-- m --><a class="postlink" href="http://forums.vtiger.com/viewtopic.php?p=12987">http://forums.vtiger.com/viewtopic.php?p=12987</a><!-- m --> and the replacement given by leokolln above, i can create quotes without error, even if the potential id is null.
  
  somebody, please, get this merged in cvs.
  
  thanks,
  ken
• emdee

  July 2006 Vote Up0Vote Down

  "anonymous&quot wrote:

  hi vtiger team,
  
  i have the same problem... v4.2.4 with a bug in quote creation. will you provide a patch or can i replace my utils.php with the solution above?
  
  thanks!
  fernando

  
  yes confirmed in my 4.2.4, the bug is caused because potential is not a required field when creating a quote. if you create a quote without potential the fatal error occurs.
• emdee

  July 2006 Vote Up0Vote Down

  leokolln solution (in this post) does appear to work.