vtiger

[Kiddo]

The problem is that Notes are displayed with extra newlines (actually embedded "<br />"s). (It took me many hours to find the guilty code! :cry:)

Here is the fix:

Near line 132 of include/utils/DetailViewUtils.php:

Remove:
Code:
   elseif($uitype == 19)
   {
        $col_fields[$fieldname]= make_clickable(nl2br($col_fields[$fieldname]));

Alternative 1: Substitute:
Code:
   elseif($uitype == 19) // Notes:
   {

In my opinion, the above is the preferred fix until a better version of make_clickable() is written. make_clickable() attempts to take text like "www.test.com" and turn it into a clickable link. However, in my test on a Note full of URLs, it does this in an inconsistent fashion; some got converted, some didn't.

If you think that inconsistent link creation is better than none then the following is the corrected code:
Alternative 2: Substitute:
Code:
   elseif($uitype == 19) // Notes:
   {
      $col_fields[$fieldname]= make_clickable($col_fields[$fieldname]);

regards,
Neil

[philip]

Hi,

Thanks for pointing this out, this has been fixed in our latest build and will be available in next release. Kindly refer our svn repository in vtiger.fosslabs.com for more details.

Philip