vtiger

[joebordes]

Hi,

I've seen that the code that uses the field vtiger_field.uitype is full of "magic numbers" (see Code Complete on Amazon). I think that all these numbers should be converted to define's, with this:
- we would make the code easier to read and maintain
- we would have documentation in the code of all the utiype defined

I am willing to do this work.

Regards, Joe.
TSolucio

[Kiddo]

This is absolutely true. I found the code very hard to follow, which is bad news for maintainability. It needs proper and extensive use of defines (without abbreviations): here are some nice examples vtiger team:
Image/Graph/Constants.php
log4php/helpers/LoggerTransform.php
log4php/LoggerPropertyConfigurator.php

regards,
Neil