vtiger

[GJdeBoer]

The invoice export to pdf did not work in RC.
I fixed a small error in Invoice.js where product_name and product_id should be replaced with invoice_name and invoice_id.

Below is the .diff:
root@siona:/home/www/virtual/nosco-ict.nl/crm/htdocs/modules/Invoice# diff Invoice.js.back Invoice.js
21,22c21,22
< var fldName = getOpenerObj("product_name");
< var fldId = getOpenerObj("product_id");
---
> var fldName = getOpenerObj("invoice_name");
> var fldId = getOpenerObj("invoice_id");
root@siona:/home/www/virtual/nosco-ict.nl/crm/htdocs/modules/Invoice#

Hope this helps.

Regards,

Gert-Jan de Boer

[codyheit]

Yes I hope that this error was going to be fixed with the RC release. We should update the code to reflect this fix!

[mmbrich]

I have a bunch of work to do on the PDFs before GA. Taxes, adjustments, etc still need to be added to most of the PDFs... I'll look into adding this patch while I am in there breaking stuff.

matt

[codyheit]

Ok thanks

I assume that vtiger 5 will not work on mysql 4?

[mmbrich]

I don't think it will but I haven't tried it.

Matt

[GJdeBoer]

mmbrich wrote: I have a bunch of work to do on the PDFs before GA. Taxes, adjustments, etc still need to be added to most of the PDFs... I'll look into adding this patch while I am in there breaking stuff.

matt
I only need working exported Invoices, sales orders can stay in the system, but I need to bill my clients.

Is there a quick workaround in the CreatePDF.php to add the Tax amount? It should just work. I guessed I could do a $total - ($subtotal-$adjustment) for now, but this doesn't work in CreatePDF because the fields are text and not numbers.

[mmbrich]

GJdeBoer wrote:
Is there a quick workaround in the CreatePDF.php to add the Tax amount? It should just work. I guessed I could do a $total - ($subtotal-$adjustment) for now, but this doesn't work in CreatePDF because the fields are text and not numbers.
I actually started my work in the Invoices just before beta. The formulas are not correct though, I was still too busy with the joomla stuff to pay any attention. Also, you can still do math functions on text fields, as long as the data you are working with is actual ints or floats your fine:
Code:
if((is_int($tax_percent) || is_float($tax_percent) && (is_int($total) || is_float($total)) {
        $total_with_tax = (($total * $tax_percent)/100);
}


I had planned on jumping back into the PDFs tomorrow, if you can wait a bit longer they will be done.. I may even get around to some of it tonight.

Matt

[codyheit]

Well it looks like we have found the first problem with version 5.

[GJdeBoer]

mmbrich wrote: GJdeBoer wrote:
Is there a quick workaround in the CreatePDF.php to add the Tax amount? It should just work. I guessed I could do a $total - ($subtotal-$adjustment) for now, but this doesn't work in CreatePDF because the fields are text and not numbers.
I actually started my work in the Invoices just before beta. The formulas are not correct though, I was still too busy with the joomla stuff to pay any attention. Also, you can still do math functions on text fields, as long as the data you are working with is actual ints or floats your fine:
Code:
if((is_int($tax_percent) || is_float($tax_percent) && (is_int($total) || is_float($total)) {
        $total_with_tax = (($total * $tax_percent)/100);
}


I had planned on jumping back into the PDFs tomorrow, if you can wait a bit longer they will be done.. I may even get around to some of it tonight.

Matt
Oh, I can wait. It works for the moment. Tomorrow my new business wil go into business, but I can work fine with a self-coded work-around for now. As long as the final version of vtiger5 will support full international invoices. (I need to replace the default currency with Euro)