vtiger

[phx]

Hi all, I wa looking some of my apache log and i have found this:
I'm using an spanish language package.

Code: [Wed Jun 28 12:59:43 2006] [error] [client xxx.xxx.xxx.xxx] File does not exist: vtiger_crm/modules/Quotes/Presupuesto.js

Searching the source of this error i found this diferences between Listview.php and DetailView.php in many modules:

eg. for Quotes module.

In ListView.php
Code: $smarty->assign("SINGLE_MOD",'Quote');

In DetailView.php
Code: $smarty->assign("SINGLE_MOD",$app_strings['Quote']);

In the include/language/es_es.lang.php:
Code: 'Quote' => 'Presupuesto'

My question is if the error belongs to de language file, or if belongs to one of this files?

Thanks

[mickie]

Dear phx,

Thanks for notifying the issue. SINGLE_MOD varaiable is used for the module name(we will include the js file based on this name) where as we should not give the app_strings value because this app_strings value will be changed in the language pack. so we should give Code: $smarty->assign("SINGLE_MOD",'Quote'); instead of Code: $smarty->assign("SINGLE_MOD",$app_strings['Quote']); in modules/Quotes/DetailView.php
we will update this.

Thanks & Regards
Mickie

[phx]

Dear Mickie,

Thanks for the quick reply.

Regards
phx

[phx]

Dears Mickie,

I notice that you update de DetailView.php of the Quote module, but the issue is in amlost every module, i list the modules that have this.

Code:
modules/Accounts/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Account']);
modules/Activities/DetailView.php:$smarty->assign("SINGLE_MOD", $app_strings['Activity']);
modules/Campaigns/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Campaign']);
modules/Contacts/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Contact']);
modules/Emails/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Email']);
modules/HelpDesk/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Ticket']);
modules/Invoice/DetailView.php:$smarty->assign("SINGLE_MOD", $app_strings['Invoice']);
modules/Leads/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Lead']);
modules/Notes/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Note']);
modules/Potentials/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Potential']);
modules/PriceBooks/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['PriceBook']);
modules/Products/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Product']);
modules/PurchaseOrder/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['PurchaseOrder']);
modules/SalesOrder/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['SalesOrder']);
modules/Vendors/DetailView.php:$smarty->assign("SINGLE_MOD",$app_strings['Vendor']);


Thanks
Guido

[mickie]

Dear Guido,

Thanks to take time to find these issues. i will change these strings and update in svn today.
Please feel free to post your findings and suggestions.
Thanks & Regards
Mickie