vtiger

[jeffk]

Could someone identify the version number of the copied adodb in the vtigercrm CVS repository?

adodb-4.67 has just been released, and for reasons of security fixes, database (postgresql) support, I would like to see the most updated version used and clearly identified in the repository and vtigercrm releases.

Assuming that the copied version is relatively old, I will at least test adodb-4.67 in place of the current version, and report any issues encountered. Thanks.

[indigoleopard]

Hi jeffk!

Long time since we got a post from you.

Good point that you made. We will capture these info in our release notes from now on.
We will also post asap the version of adodb being used currently.


Richie

[philip]

Hi jeffk,

We are bunding adodb 4.55 with our vtigerCRM.
Awaiting for your report on the latest version of adodb with vtigerCRM

Philip

[jeffk]

I have tested vtigercrm (cvs checkout updated as of 2005-11-22 EST) with the internal 'adodb' directory contents changed to adodb-4.67.

The test (fresh vtiger install, populate sample data, visit a few items in the database) was without error. It was indistinguishable from the original adodb-4.55 currently in CVS.

Based on this test, and the good sense of keeping current with adodb. I recommend that vtigercrm either:

a) upgrade the contents of the adodb copy to adodb-4.67, or

b) change adodb to an external dependency, so that the operating system packages or adodb will provide future updates. Gentoo linux puts adodb in the following location: /usr/share/php/adodb/, so it should be a simple matter to change the installer to look for this directory and version as one more dependency.

I prefer option B, definitely.

Don't forget to remove the following files when merging adodb-4.55 to 4.67 if not removing the internal copy outright:

$ cat cleanvtigercrmcvsadodb.sh
rm -rf vtiger_crm/cute_icons_for_site ;
rm -rf vtiger_crm/docs ;
rm rm vtiger_crm/adodb/pear/Auth/readme.Auth.txt ;
rm vtiger_crm/adodb/session/adodb-sess.txt ;
rm vtiger_crm/adodb/session/adodb-sessions.mysql.sql ;
rm vtiger_crm/adodb/session/adodb-sessions.oracle.clob.sql ;
rm vtiger_crm/adodb/session/adodb-sessions.oracle.sql ;
rm vtiger_crm/adodb/adodb-perf.inc.php.#.LENS-03-09-05 ;
rm vtiger_crm/adodb/adodb-time.zip ;
rm vtiger_crm/adodb/license.txt ;
rm vtiger_crm/adodb/readme.txt ;
rm vtiger_crm/adodb/xmlschema.dtd ;
rm vtiger_crm/adodb/tests/xmlschema.xml ;

I left the schema file vtiger_crm/adodb/DatabaseSchema.xml in place. Please move this to another location, so adodb/ has no file differences with the official adodb-4.67 package.

I hope that you will let Mike Crowe modularize the Schema.xml as proposed soon anyway.

Thanks. Please update to adodb-4.67 before the release. Seems fine, but anything that suddenly doesn't work with 4.67 is a bug and should be fixed anyway.

[jeffk]

adodb-4.68 has been released:
http://freshmeat.net/projects/adodb/?branch_id=122&release_id=215082
Code: Changes:
Fixes to PostgreSQL drivers to support PHP 5.1, partial PDO support, support for PHP 5.1, PHP 5 compatibility for mysqli, and many PDO improvements. A spelling error has been fixed in the MySQL MetaForeignKeys $associative parameter. MetaForeignKeys was repeated twice and the MYSQLI_BINARY_FLAG was missing. PHP 5.1 support for PostgreSQL bind parameters using ? now works.
(the PHP4 changes happened long ago, FWIW)

For the reasons mentioned earlier in this thread, it would be a good idea to sync the CVS branches leading toward vtigercrm-5.0.0-alpha1 and vtigercrm-4.2.3 with adodb-4.68, deleting various extra files that wound up in vtigercrm's local copy of adodb-4.55.

Given the recent attention to SQL (injection) security, updating to the latest adodb-4.68 is an easy security win. http://phplens.com/lens/adodb/docs-adodb.htm#changelog It will also ease the task of the postgresql-support contributors, which will probably be resurgent after vtigercrm-5.0.0-alpha1 and vtigercrm-4.2.3 releases.

I notice that the VTIGERCRM_4_2_PATCH2_INTEG_POSTGRES_BRANCH has already done some work on this, which might ease the task:
Quote: Subject: vtiger_crm/adodb/session adodb-compress-bzip2.php,NONE,1.1.6.2 adodb-compress-gzip.php,NONE,1.1.6.2 adodb-cryptsession.php,NONE,1.1.6.2 adodb-encrypt-mcrypt.php,NONE,1.1.6.2 adodb-encrypt-md5.php,NONE,1.1.6.2 adodb-encrypt-secret.php,NONE,1.1.6.2 adodb-encrypt-sha1.php,NONE,1.1.2.1 adodb-sess.txt,NONE,1.1.6.2 adodb-session-clob.php,NONE,1.1.6.2 adodb-session.php,NONE,1.1.6.2 adodb-sessions.mysql.sql,NONE,1.1.6.2 adodb-sessions.oracle.clob.sql,NONE,1.1.6.2 adodb-sessions.oracle.sql,NONE,1.1.6.2 crypt.inc.php,NONE,1.1.6.2 session_schema.xml,NONE,1.1.2.1
From: allanbush-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Newsgroups: gmane.comp.web.vtigercrm.repository
Date: Mon, 5 Dec 2005 22:39:07 -0800 (PST)

Update of /cvsroot/vtigercrm/vtiger_crm/adodb/session
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23180/adodb/session

Added Files:
Tag: VTIGERCRM_4_2_PATCH2_INTEG_POSTGRES_BRANCH
adodb-compress-bzip2.php adodb-compress-gzip.php
adodb-cryptsession.php adodb-encrypt-mcrypt.php
adodb-encrypt-md5.php adodb-encrypt-secret.php
adodb-encrypt-sha1.php adodb-sess.txt adodb-session-clob.php
adodb-session.php adodb-sessions.mysql.sql
adodb-sessions.oracle.clob.sql adodb-sessions.oracle.sql
crypt.inc.php session_schema.xml
Log Message:
Lastest version of adodb
Quote: Subject: vtiger_crm/install DatabaseSchema.xml,NONE,1.1.2.1
From: allanbush-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Newsgroups: gmane.comp.web.vtigercrm.repository
Date: Mon, 5 Dec 2005 22:36:05 -0800 (PST)

Update of /cvsroot/vtigercrm/vtiger_crm/install
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22816

Added Files:
Tag: VTIGERCRM_4_2_PATCH2_INTEG_POSTGRES_BRANCH
DatabaseSchema.xml
Log Message:
Moved out of adodb directory to allow for adodb version changes and updated constraint syntax to work with the current version of adodb.

[indigoleopard]

Hi Jeff!

Is it as easy as dropping the new adodb version in the adodb folder or are there any additional changes that ought to be done? What I mean to ask is, if I just delete the contents of the existing adodb folder and drop the new one in, will it sing better than before?
A contribution from you is in order in that case :D !

Richie

[Bushwack]

Riche,

In the POSTGRES branch I simply moved the DatabaseSchema.xml out of the adodb directory then replaced the existing adodb directory with the newest version. I haven't noticed any ill effects caused by this in either mysql or postgres.

As I've mentiioned to you before I'd suggest mirgating the changes in the postgres branch into the trunk (I can provide diff files if that's easier for you) at this time. That way we get an updated adodb version and a simple path to further updates (I'll have to check if the one small change I made to adodb to get the postgres install working has landed up stream in the lastest version first).

[jeffk]

indigoleopard wrote: Is it as easy as dropping the new adodb version in the adodb folder or are there any additional changes that ought to be done?
I just now tested adodb-4.68 dropped in place of vtigercrm CVS HEAD's local customized copy of adodb-4.55. The only diff is the presence of DatabaseSchema.xml. I removed a few customized calls to loggers in adodb-datadict.inc.php. There are other miscellaneous files and directories that I delete to match adob-4.68 contents exactly.

The test results are the same, I can run through install.php with a new database and populate sample data. Anything that doesn't work after that is a bug, wouldn't you agree? Lets find them by committing adodb-4.68 to HEAD and VTIGERCRM_4_2_BRANCH.

If you follow bushwack's suggestion to move DatabaseSchema.xml out of the adodb/ directory, you can eliminate your local copy of adodb from the repository, and make it an external dependency, e.g. adodb>=4.68.

There are many external dependencies for vtiger anyway, it is unwise to retain local copies of any libraries, and inconvenient for packagers and deployers who must audit security of deployed libraries per company policy (I don't have that burden, personally, but it's been mentioned by the people submitting patches against SQL injection).

[jeffk]

Bushwack wrote: As I've mentiioned to you before I'd suggest mirgating the changes in the postgres branch into the trunk (I can provide diff files if that's easier for you) at this time. That way we get an updated adodb version and a simple path to further updates (I'll have to check if the one small change I made to adodb to get the postgres install working has landed up stream in the lastest version first).
Postgresql support would be the most beneficial feature on my list, I don't want to use mysql. At all.

However, is the postgresql support ready now? If it still has a way to go, it would be wise to have that be among the first commits following vtigercrm-4.2.3 and vtigercrm-5.0.0-alpha1, so that postgresql might be fully supported by a vtigercrm-4.2.4* and vtigercrm-5.0.0-alpha2 very shortly thereafter (like, a few weeks).

* If you consider adding postgresql support a bugfix, since we're 'using adodb more properly'. Otherwise it would be named vtigercrm-4.3.0, and could also have other features added.

[Bushwack]

jeffk wrote: However, is the postgresql support ready now?

No, all that's really done right now is that the installation process is working properly. However there is so much restructing going on in the CVS trunk right now that imo it's nearly impossible to expect to be able to merge any work done in a branch. As such I think what's been done so far should be merged (well we still can) and a new branch created when things settle down a little.